Xinyi - fix: longst open issues chart#4301
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
- I followed the provided test plan (fresh install, cache cleared, logged in as owner) to verify this PR. The changes successfully address the text overlap and visibility issues described in the PR.
- Date Range Filter: Works correctly and allows users to select start and end dates.
- Projects Filter: Functions correctly with multi-select capability and includes a reset button to clear all selected projects.
- Text Overlap: The text overlap issue has been resolved. All chart data and labels are now clearly visible without overlapping.
- Responsive Design: The page is responsive and adapts well to smaller screen sizes, with labels appropriately hidden on mobile devices as designed.
Issues Identified:
-
Missing Projects Filter Label: The projects filter dropdown lacks a visible label, which reduces clarity about what the filter controls. Consider adding a label similar to the date range filter (e.g., "Projects:").
-
Date Range Reset Functionality: The projects filter includes a reset button to clear all selections, but the date range filters do not have a similar clear/reset mechanism. For consistency and better UX, consider adding clear buttons or an
isClearableprop to the DatePicker components. -
Dark Mode Visibility Issues:
- Date Range Labels: The "From" and "To" labels are not clearly visible in dark mode. The CSS includes a
.dark .dateLabelselector (line 70), but the component uses conditional class application rather than a parent.darkclass, so this styling is not being applied.
- React-Select Dropdown Styling: The dropdown menu items in the projects filter are not readable in dark mode. The current implementation only applies a
selectDarkclass, which doesn't properly style the dropdown menu, options, or other React-Select components.
-
The migration from global CSS to CSS modules is an improvement for maintainability. Using
useMemofor data normalization is appropriate for performance optimization. The responsive grid layout implementation is clean and well-structured. -
Test Video:
TestVideo.mov
Overall Assessment:
The PR successfully resolves the primary text overlap and visibility issues in light mode. However, the dark mode styling needs attention to ensure all UI elements are clearly visible and accessible. The suggested improvements would enhance consistency with other components in the codebase and improve the user experience across both light and dark themes.
b9dcebd to
580f04c
Compare
|
bhanuanishakkineni
left a comment
There was a problem hiding this comment.
I have reviewed and tested this PR through logging as an admin and directing to total Construction summary page.
I tested the longest open issues chart through following steps:
Project filter: Was able to select single and multiple projects as filters and was able to clear filter easily.
Date filter: Able to pick start date and end date between which I wish to see the issues. Also able to clear the date filters.
For all the filters and no filters, there is no text overlap and the data is visible clearly and is readable.
Even during the dark mode, the chart is functional and the text and the data are readable.
Finally, the page is responsive for all screen sizes in both light and dark mode without any overlaps and data readability.
PR.4301.testing.mp4
|
Thank you all, merging! |










Description
Related PRS (if any):
#3660 + #1463
Main changes explained:
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
before:

after:

Note:
Include the information the reviewers need to know.